Chain exceptions from LibsecretPersistence #20380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
xiangyan99
reviewed
Aug 23, 2021
| raise ValueError( | ||
| "PyGObject is required to encrypt the persistent cache. Please install that library or " | ||
| + 'specify "allow_unencrypted_storage=True" to store the cache without encryption.' | ||
| error = ValueError( |
There was a problem hiding this comment.
Why don't we explicitly tell users we need PyGObject to work?
There was a problem hiding this comment.
To avoid having to keep this message up to date with msal-extensions. It may stop requiring PyGObject, or require a different version of it (it's a runtime dependency). The details of the error aren't lost; msal-extensions includes them in the exception we're raising from. Having written this I'm thinking our message should be even less specific, because this one is misleading when we can't encrypt because we're in an SSH session.
There was a problem hiding this comment.
Could you give me more information that other than ImportError, which error(s) we want to cover here?
There was a problem hiding this comment.
The next version of msal-extensions may raise ValueError or RuntimeError as well as ImportError (code is here). It might also be possible for us to see an unexpected (by msal-extensions) PyGObject exception. Handling all exceptions here appeals to me because I don't want to rely too much on the current behavior of msal-extensions, and for us the particular exception isn't important.
There was a problem hiding this comment.
I am fine with that. The only question I think would be do we want to give different error messages for different types of error so it can be more actionable for users to fix them?
There was a problem hiding this comment.
msal-extensions does that with its errors, so by chaining them we give users the details without depending on how msal-extensions handles libsecret/PyGObject errors.
xiangyan99
approved these changes
Aug 23, 2021
mccoyp
approved these changes
Aug 23, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 25, 2021
…into switch_to_rest * 'main' of https://github.com/Azure/azure-sdk-for-python: Address API view issues (Azure#20407) skip custom translation model samples (Azure#20414) [purview account] first release for azure-purview-account (Azure#20335) improve docs and samples for glossaries and custom models (Azure#18587) Sync eng/common directory with azure-sdk-tools for PR 1918 (Azure#20342) Update .docsettings.yml (Azure#20402) improve begin_translation docstring (Azure#20401) [translation] fix poller.details (Azure#20392) Chain exceptions from LibsecretPersistence (Azure#20380) [AutoRelease] t2-datamigration-2021-08-19-04035 (Azure#20349) [AutoRelease] t2-policyinsights-2021-08-23-78735 (Azure#20381) [AutoRelease] t2-servicebus-2021-08-19-00756 (Azure#20350) [AutoRelease] t2-costmanagement-2021-07-27-84467 (Azure#19949) keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (Azure#20391) Add Cloud Configuration section to Identity readme (Azure#20373) Consistency related changes (Azure#20385)
iscai-msft
added a commit
that referenced
this pull request
Aug 25, 2021
…into header_tuples * 'main' of https://github.com/Azure/azure-sdk-for-python: (23 commits) make core tests offline (#19986) [translation] naming alignment (#20406) Address API view issues (#20407) skip custom translation model samples (#20414) [purview account] first release for azure-purview-account (#20335) improve docs and samples for glossaries and custom models (#18587) Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342) Update .docsettings.yml (#20402) improve begin_translation docstring (#20401) [translation] fix poller.details (#20392) Chain exceptions from LibsecretPersistence (#20380) [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349) [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381) [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350) [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949) keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391) Add Cloud Configuration section to Identity readme (#20373) Consistency related changes (#20385) Document Pod Identity's special use of client_id (#20377) [rest] use azure json encoder for json input bodies (#20361) ...
hildurhodd
pushed a commit
to hildurhodd/azure-sdk-for-python
that referenced
this pull request
Aug 26, 2021
hildurhodd
pushed a commit
to hildurhodd/azure-sdk-for-python
that referenced
this pull request
Aug 26, 2021
hildurhodd
pushed a commit
to hildurhodd/azure-sdk-for-python
that referenced
this pull request
Aug 30, 2021
msyyc
added a commit
that referenced
this pull request
Aug 30, 2021
* CodeGen from PR 15691 in Azure/azure-rest-api-specs [NetAppFiles] fix default in volumeproperties (#15691) * fix default in volumeproperties * Update description * Update description Co-authored-by: Audunn Baldvinsson <[email protected]> * version,CHANGELOG * test * bump node version (#20353) * Remove old unused update changelog script (#20357) Co-authored-by: Wes Haggard <[email protected]> * Handle value types for results (#20358) * Handle value types for results * update test * lint * comprehension * more precis * fix test * [rest] change text from a property to a method (#20290) * [ServiceBus] update migration guide with message count info (#20360) #20245 * Update CODEOWNERS (#20366) * More Renaming in query (#20303) * More Reanaming in query * changelog * commit 2 * some changes * remove errror * Update sdk/monitor/azure-monitor-query/azure/monitor/query/_models.py * Apply suggestions from code review Co-authored-by: Adam Ling (MSFT) <[email protected]> * Update sdk/monitor/azure-monitor-query/CHANGELOG.md Co-authored-by: Adam Ling (MSFT) <[email protected]> * Fix Monitor opentelemetry exporter readme issues (#19038) * [Key Vault] Add 7.3-preview support for administration (#20364) * Update metadata values (#20365) * Update metadata values * distributed trace * oops * Update sdk/monitor/azure-monitor-query/CHANGELOG.md * Apply suggestions from code review * Bug fix for pipeline downloading incorrect package ver (#20294) * Bug fix: pipeline to download correct package ver * Update clean version * Update clean version * Cleanup * Cleanup * Cleanup * Cleanup * Comments added * Testing * Final-Version * CertificateCredential supports PKCS12 certs (#16384) * [rest] use azure json encoder for json input bodies (#20361) * Document Pod Identity's special use of client_id (#20377) * Consistency related changes (#20385) * time stamp * Rename AggragationType to MetricAggregationType * Metric Class * logs batch result * MetricNamespaceClassification * LogsTable + LogsTableColumn * lint * more lint * Add Cloud Configuration section to Identity readme (#20373) * keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391) * [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949) * CodeGen from PR 15291 in Azure/azure-rest-api-specs Updating Query filter description (#15291) Co-authored-by: Jorge Chavez Nieto <[email protected]> * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: Jorge Chavez Nieto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350) * CodeGen from PR 14749 in Azure/azure-rest-api-specs add apitestErrorCode doc (#14749) * add apitestErrorCode doc * add armRPC doc * add roundTripInconsistentProperty doc * small fix * update * update signalR armTemplate * update yaml * new file * add testScenario with armTemplate * update doc * update readme.md * update doc * update NOTE section * add signalRCreateOrUpdate example file * udpate doc * add generate test scenario section * update doc * add serviceFacbric test scenario file * update managedClusters.yaml * update generateABasicTestScenario.md * update features doc * add run api test gif * version,CHANGELOG * test * Update test_cli_mgmt_servicebus_namespace.py * Update test_queues.py * Update test_queues.py Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: Jiefeng Chen <[email protected]> * [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381) * CodeGen from PR 15165 in Azure/azure-rest-api-specs [policyinsights] Fix next_link (#15165) * fix next_link * directive * Update readme.nodejs.md * js directvie * Update readme.md * supress other language * Update readme.go.md * swagger lint * swagger lint * swagger lint * Update readme.md * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Zed Lei <[email protected]> * [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349) * CodeGen from PR 15259 in Azure/azure-rest-api-specs Dev datamigration microsoft.data migration 2021 06 30 (#15259) * Created new api version and refactoring changes (such as fixing new build restrictions) * Adding breaking changes * Adding location to the services update example * Adding location for projects update and refactoring the task command * Resolving tasks command ModelValidation test failure * Resolving issue based on zhenglaizhang's recommendation * Adding comma to resolve issue Co-authored-by: Artem Pavlichenko <[email protected]> * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: Artem Pavlichenko <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Chain exceptions from LibsecretPersistence (#20380) * [translation] fix poller.details (#20392) * fixing docstring types for async client * populate poller.details.id immediately * pylint * add bug fix to changelog * improve begin_translation docstring (#20401) * Update .docsettings.yml (#20402) * Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342) * Stress test deployment script resiliency fixes * Use PSModule-Helpers to install powershell-yaml Co-authored-by: Ben Broderick Phillips <[email protected]> * improve docs and samples for glossaries and custom models (#18587) * update the readme * update readme file * added custom translation samples * fix 'no-locale' thing in links * update glossary docs * update glossaries * link to sample glossaries instead of writing code in readme * update custom model sample linking * remove relative linking in readme * make subheadings in bold text to be more readable * conform with 'Document Translation' naming * disambiguate container sas url * capitaliz Azure name * remove misplaced period * update samples -> custom model * update async sample -> custom model * remove localization from url * update readme with new file types for glossaries * adding sample glossaries -> xlf * white space * use simplified single input method * update 'job' terminology * update azure-core naming * update glossary blob file reference name * link to supported glossaries table * remove locale from url * [purview account] first release for azure-purview-account (#20335) * purview account * CI * verion-tolerant * endpoint order * add test for collections * Update CHANGELOG.md * review * update reamdme * skip custom translation model samples (#20414) * Address API view issues (#20407) * logs client * lc-2 * models changes * more changes * more changes * more arch changes * changelog * tests * lint * fix tests * timespan * [translation] naming alignment (#20406) * list_all_translation_statuses -> list_translation_statuses * list_all_document_statuses -> list_document_statuses * cancelled -> canceled, cancelling -> canceling * FileFormat -> DocumentTranslationFileFormat * update changelog * make core tests offline (#19986) * make core tests offline * clean up * use localhost instead of 127.0.0.1 * update * update * update * Get rid of LogsBatchQueryResult (#20418) * Get rid of LogsBatchQueryResult * Update sdk/monitor/azure-monitor-query/README.md * oops * comments * [AutoRelease] t2-iothub-2021-08-25-25696 (#20409) * CodeGen from PR 15722 in Azure/azure-rest-api-specs Removing readonly for isVerified property as it is no more readonly property (#15722) * version,CHANGELOG * test Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422) * CodeGen from PR 15381 in Azure/azure-rest-api-specs Update readme.md (#15381) * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Stip empty changelog sections before release (#20437) Co-authored-by: Chidozie Ononiwu <[email protected]> * Update question-answering readme links (#20439) * ensure test principal creation succeeds properly (#20446) Co-authored-by: scbedd <[email protected]> * New dummy password in README (#20328) * Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450) * Bug fix: Storing .env file for bicep file at service dir * Styling Co-authored-by: Albert Cheng <[email protected]> * [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423) * CodeGen from PR 15458 in Azure/azure-rest-api-specs Add rotation permission (#15458) * Add rotation permission * Update keys.json Remove required from lifetimeActions * Change to expiryTime * version,CHANGELOG * test Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * new recordings Co-authored-by: SDKAuto <[email protected]> Co-authored-by: Audunn Baldvinsson <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: iscai-msft <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: swathipil <[email protected]> Co-authored-by: McCoy Patiño <[email protected]> Co-authored-by: Adam Ling (MSFT) <[email protected]> Co-authored-by: Tong Xu (MSFT) <[email protected]> Co-authored-by: ckairen <[email protected]> Co-authored-by: Charles Lowell <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Azure CLI Bot <[email protected]> Co-authored-by: Jorge Chavez Nieto <[email protected]> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: Jiefeng Chen <[email protected]> Co-authored-by: Artem Pavlichenko <[email protected]> Co-authored-by: Krista Pratico <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Mohamed Shaban <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: Xiang Yan <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: annatisch <[email protected]> Co-authored-by: Albert Cheng <[email protected]>
iscai-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
iscai-msft
added a commit
that referenced
this pull request
Sep 29, 2021
* CodeGen from PR 15691 in Azure/azure-rest-api-specs [NetAppFiles] fix default in volumeproperties (#15691) * fix default in volumeproperties * Update description * Update description Co-authored-by: Audunn Baldvinsson <[email protected]> * version,CHANGELOG * test * bump node version (#20353) * Remove old unused update changelog script (#20357) Co-authored-by: Wes Haggard <[email protected]> * Handle value types for results (#20358) * Handle value types for results * update test * lint * comprehension * more precis * fix test * [rest] change text from a property to a method (#20290) * [ServiceBus] update migration guide with message count info (#20360) #20245 * Update CODEOWNERS (#20366) * More Renaming in query (#20303) * More Reanaming in query * changelog * commit 2 * some changes * remove errror * Update sdk/monitor/azure-monitor-query/azure/monitor/query/_models.py * Apply suggestions from code review Co-authored-by: Adam Ling (MSFT) <[email protected]> * Update sdk/monitor/azure-monitor-query/CHANGELOG.md Co-authored-by: Adam Ling (MSFT) <[email protected]> * Fix Monitor opentelemetry exporter readme issues (#19038) * [Key Vault] Add 7.3-preview support for administration (#20364) * Update metadata values (#20365) * Update metadata values * distributed trace * oops * Update sdk/monitor/azure-monitor-query/CHANGELOG.md * Apply suggestions from code review * Bug fix for pipeline downloading incorrect package ver (#20294) * Bug fix: pipeline to download correct package ver * Update clean version * Update clean version * Cleanup * Cleanup * Cleanup * Cleanup * Comments added * Testing * Final-Version * CertificateCredential supports PKCS12 certs (#16384) * [rest] use azure json encoder for json input bodies (#20361) * Document Pod Identity's special use of client_id (#20377) * Consistency related changes (#20385) * time stamp * Rename AggragationType to MetricAggregationType * Metric Class * logs batch result * MetricNamespaceClassification * LogsTable + LogsTableColumn * lint * more lint * Add Cloud Configuration section to Identity readme (#20373) * keyvault and storage have a conflict between mindependency and what local azure-identity requires. resolve it (#20391) * [AutoRelease] t2-costmanagement-2021-07-27-84467 (#19949) * CodeGen from PR 15291 in Azure/azure-rest-api-specs Updating Query filter description (#15291) Co-authored-by: Jorge Chavez Nieto <[email protected]> * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: Jorge Chavez Nieto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * [AutoRelease] t2-servicebus-2021-08-19-00756 (#20350) * CodeGen from PR 14749 in Azure/azure-rest-api-specs add apitestErrorCode doc (#14749) * add apitestErrorCode doc * add armRPC doc * add roundTripInconsistentProperty doc * small fix * update * update signalR armTemplate * update yaml * new file * add testScenario with armTemplate * update doc * update readme.md * update doc * update NOTE section * add signalRCreateOrUpdate example file * udpate doc * add generate test scenario section * update doc * add serviceFacbric test scenario file * update managedClusters.yaml * update generateABasicTestScenario.md * update features doc * add run api test gif * version,CHANGELOG * test * Update test_cli_mgmt_servicebus_namespace.py * Update test_queues.py * Update test_queues.py Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: Jiefeng Chen <[email protected]> * [AutoRelease] t2-policyinsights-2021-08-23-78735 (#20381) * CodeGen from PR 15165 in Azure/azure-rest-api-specs [policyinsights] Fix next_link (#15165) * fix next_link * directive * Update readme.nodejs.md * js directvie * Update readme.md * supress other language * Update readme.go.md * swagger lint * swagger lint * swagger lint * Update readme.md * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Zed Lei <[email protected]> * [AutoRelease] t2-datamigration-2021-08-19-04035 (#20349) * CodeGen from PR 15259 in Azure/azure-rest-api-specs Dev datamigration microsoft.data migration 2021 06 30 (#15259) * Created new api version and refactoring changes (such as fixing new build restrictions) * Adding breaking changes * Adding location to the services update example * Adding location for projects update and refactoring the task command * Resolving tasks command ModelValidation test failure * Resolving issue based on zhenglaizhang's recommendation * Adding comma to resolve issue Co-authored-by: Artem Pavlichenko <[email protected]> * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: Artem Pavlichenko <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Chain exceptions from LibsecretPersistence (#20380) * [translation] fix poller.details (#20392) * fixing docstring types for async client * populate poller.details.id immediately * pylint * add bug fix to changelog * improve begin_translation docstring (#20401) * Update .docsettings.yml (#20402) * Sync eng/common directory with azure-sdk-tools for PR 1918 (#20342) * Stress test deployment script resiliency fixes * Use PSModule-Helpers to install powershell-yaml Co-authored-by: Ben Broderick Phillips <[email protected]> * improve docs and samples for glossaries and custom models (#18587) * update the readme * update readme file * added custom translation samples * fix 'no-locale' thing in links * update glossary docs * update glossaries * link to sample glossaries instead of writing code in readme * update custom model sample linking * remove relative linking in readme * make subheadings in bold text to be more readable * conform with 'Document Translation' naming * disambiguate container sas url * capitaliz Azure name * remove misplaced period * update samples -> custom model * update async sample -> custom model * remove localization from url * update readme with new file types for glossaries * adding sample glossaries -> xlf * white space * use simplified single input method * update 'job' terminology * update azure-core naming * update glossary blob file reference name * link to supported glossaries table * remove locale from url * [purview account] first release for azure-purview-account (#20335) * purview account * CI * verion-tolerant * endpoint order * add test for collections * Update CHANGELOG.md * review * update reamdme * skip custom translation model samples (#20414) * Address API view issues (#20407) * logs client * lc-2 * models changes * more changes * more changes * more arch changes * changelog * tests * lint * fix tests * timespan * [translation] naming alignment (#20406) * list_all_translation_statuses -> list_translation_statuses * list_all_document_statuses -> list_document_statuses * cancelled -> canceled, cancelling -> canceling * FileFormat -> DocumentTranslationFileFormat * update changelog * make core tests offline (#19986) * make core tests offline * clean up * use localhost instead of 127.0.0.1 * update * update * update * Get rid of LogsBatchQueryResult (#20418) * Get rid of LogsBatchQueryResult * Update sdk/monitor/azure-monitor-query/README.md * oops * comments * [AutoRelease] t2-iothub-2021-08-25-25696 (#20409) * CodeGen from PR 15722 in Azure/azure-rest-api-specs Removing readonly for isVerified property as it is no more readonly property (#15722) * version,CHANGELOG * test Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422) * CodeGen from PR 15381 in Azure/azure-rest-api-specs Update readme.md (#15381) * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * Stip empty changelog sections before release (#20437) Co-authored-by: Chidozie Ononiwu <[email protected]> * Update question-answering readme links (#20439) * ensure test principal creation succeeds properly (#20446) Co-authored-by: scbedd <[email protected]> * New dummy password in README (#20328) * Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450) * Bug fix: Storing .env file for bicep file at service dir * Styling Co-authored-by: Albert Cheng <[email protected]> * [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423) * CodeGen from PR 15458 in Azure/azure-rest-api-specs Add rotation permission (#15458) * Add rotation permission * Update keys.json Remove required from lifetimeActions * Change to expiryTime * version,CHANGELOG * test Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> * new recordings Co-authored-by: SDKAuto <[email protected]> Co-authored-by: Audunn Baldvinsson <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: iscai-msft <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: swathipil <[email protected]> Co-authored-by: McCoy Patiño <[email protected]> Co-authored-by: Adam Ling (MSFT) <[email protected]> Co-authored-by: Tong Xu (MSFT) <[email protected]> Co-authored-by: ckairen <[email protected]> Co-authored-by: Charles Lowell <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Azure CLI Bot <[email protected]> Co-authored-by: Jorge Chavez Nieto <[email protected]> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: Jiefeng Chen <[email protected]> Co-authored-by: Artem Pavlichenko <[email protected]> Co-authored-by: Krista Pratico <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Mohamed Shaban <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: Xiang Yan <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: annatisch <[email protected]> Co-authored-by: Albert Cheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we expect only ImportError, but constructing LibsecretPersistence could raise ValueError instead. The type of the exception doesn't matter for our purposes, so this PR broadens the except clause to handle all exceptions the same way: if the application allows unencrypted storage, fall back to that; if not, raise a ValueError from the LibsecretPersistence error, to preserve the msal-extensions error message explaining what went wrong.